impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Knupp (Code Review)" <>
Subject [Impala-ASF-CR] Add .pep8rc for Impala's Python style
Date Thu, 23 Feb 2017 17:25:58 GMT
David Knupp has posted comments on this change.

Change subject: Add .pep8rc for Impala's Python style

Patch Set 1:

File .pep8rc:

PS1, Line 2: # E101 - Reindent all lines.
> Without E101 and E111, autopep8 will re-indent the whole file to use 4 spac
For what it's worth, pursuant to the discussion on dev@, I don't think this is our one shot
at this. As a first goal (setting up tooling), I think that ignoring this is probably OK.
We can revisit later, right?

PS1, Line 6: Add missing blank line
Does making the description more verbose affect the functionality?

"Expected 1 blank line, found 0. Add missing blank line."
Commit Message:

PS1, Line 7: Add .pep8rc for Impala's Python style
> No tools are automatically affected by this, but several can use it if poin
I would appreciate having this pointed out here. Just speaking for myself, if I had questions
about this file, I'd probably start by looking at the git log and read the commit messages
before I searched on a wiki somewhere.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I65a99fc6e364eb1e49e21d0ba97546bc25f65a27
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <>
Gerrit-Reviewer: David Knupp <>
Gerrit-Reviewer: Jim Apple <>
Gerrit-Reviewer: Lars Volker <>
Gerrit-Reviewer: Michael Brown <>
Gerrit-HasComments: Yes

View raw message