impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Patch references to Cloudera and CDH in Impala tutorial
Date Thu, 23 Feb 2017 06:50:31 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: Patch references to Cloudera and CDH in Impala tutorial
......................................................................


Patch references to Cloudera and CDH in Impala tutorial

There was one tutorial that actually ran under the
'cloudera' user and so repeated that name over and
over in directory and HDFS paths. I switched that to
'username'.

I suppressed some <note> and <li> tags with Cloudera
Manager-specific details. Will physically remove those
from the source in a subsequent iteration.

I left several instances of audience="Cloudera" because
those will be changed to audience="hidden" as part of
a separate change request.

I marked with rev="upstream" some <codeblock> tags
containing impala-shell banners with a Cloudera copyright
statement. Will decide on a convention to handle those
(elide those lines, or use a conref to consistently
substitute the generic equivalent) and do that in a
followup patch set.

Change-Id: I44245b65ce6f247ae8771f582f4b33c3712145ae
Reviewed-on: http://gerrit.cloudera.org:8080/5663
Reviewed-by: Laurel Hale <laurel@cloudera.com>
Reviewed-by: Jim Apple <jbapple-impala@apache.org>
Tested-by: Impala Public Jenkins
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_tutorial.xml
2 files changed, 27 insertions(+), 27 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Jim Apple: Looks good to me, approved
  Laurel Hale: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.cloudera.org:8080/5663
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I44245b65ce6f247ae8771f582f4b33c3712145ae
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>

Mime
View raw message