impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Russell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3403: [DOCS] Pare back irrelevant installation info
Date Thu, 23 Feb 2017 01:37:39 GMT
John Russell has posted comments on this change.

Change subject: IMPALA-3403: [DOCS] Pare back irrelevant installation info
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6005/1/docs/topics/impala_install.xml
File docs/topics/impala_install.xml:

Line 48:       Follow these steps to set up Impala on a cluster by building from source:
> This is odd wording. I think it might be better to say that this guide has 
Done


Line 66:       <li>
> I think the README.md is the best place for build instructions, since that 
The README.md file:

https://github.com/apache/incubator-impala/blob/master/README.md

currently is pretty slim pickings. It just says Impala requires Linux (no distro names or
numbers) and for building, it sends the user elsewhere:

"See bin/bootstrap_build.sh."

Why don't I leave the link to the wiki for the time being, and add a reference to the README
as well. We can reconsider taking out the wiki link if we later beef up the README file.


-- 
To view, visit http://gerrit.cloudera.org:8080/6005
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia81b1afbf04b93c322b9829d9e05e7af4243c37c
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Greg Rahn <grahn@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message