impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-3586: Implement union passthrough
Date Thu, 23 Feb 2017 01:04:25 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-3586: Implement union passthrough

Patch Set 7:


I'm pretty happy with this change
File be/src/exec/union-node.h:

Line 67:   // Which children can be passed through, without being materialized.
duplicate 'without'
File common/thrift/ImpalaInternalService.thrift:

Line 225:   // Indicates whether passthrough should be disabled in union nodes.
File common/thrift/ImpalaService.thrift:

PS8, Line 255: d
File fe/src/main/java/org/apache/impala/planner/

Line 267:       // nullability can be considered to be part of the physical row layout.
remove (this was moved inside computePassThrough
File testdata/workloads/functional-query/queries/QueryTest/union.test:

Line 1059: select bigint_col from functional.alltypestiny where bigint_col > 0
use unqualified table names everywhere (and fix the one above while you are here), so we get
coverage over all file formats

Line 1124: ---- QUERY
Move this test into nested-types-subplan.test, otherwise this test will fail on the legacy
joins/agg build since nested types are not supported there (nested-types-subplan.test will
be skipped)

Line 1126: select COUNT(c.c_custkey), COUNT(v.tot_price)
lowercase count

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8f6d5062724ba5b78174c3227a7a796d10d8416
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Taras Bobrovytsky <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message