impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zach Amsden (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4936 and IMPALA-4915: Fix decimal overflow test
Date Wed, 22 Feb 2017 05:47:46 GMT
Zach Amsden has posted comments on this change.

Change subject: IMPALA-4936 and IMPALA-4915: Fix decimal overflow test
......................................................................


Patch Set 2:

(3 comments)

I'm folding this into the cast change anyway.

http://gerrit.cloudera.org:8080/#/c/6068/1//COMMIT_MSG
Commit Message:

Line 22: 
> I think this probably should be fixed in this commit.
This was a real problem, found it.


http://gerrit.cloudera.org:8080/#/c/6068/2/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

PS2, Line 1397: true
> Sorry, I may be missing something. Why is this NULL ?
I am missing something too... was the test broken before?


Line 1635:         TestIsNotNull(c.expr, type);
I added this because I noticed the non-NULL test cases were passing even when the value happened
to match, which was the case for some zero values.  Looks like something is broken with modulus.


-- 
To view, visit http://gerrit.cloudera.org:8080/6068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8de7440a585c1d3d937fcbb435b9ead77e7b5a63
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message