impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2020, 4915, 4936: Add rounding for decimal casts
Date Wed, 22 Feb 2017 04:31:27 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts
......................................................................


Patch Set 17:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5951/17/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

PS17, Line 1395: N.B. - with full decimal V2 this should evaluate to 1
How so? We've already added the new V2 result type formula for %, and you get decimal(38,
38) in this case which is consistent with other engines.  what type would be a better choice?


-- 
To view, visit http://gerrit.cloudera.org:8080/5951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2daf186b4770a022f9cb349d512067a1dd624810
Gerrit-PatchSet: 17
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message