impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4877: fix precedence of unary -/+
Date Tue, 21 Feb 2017 23:58:35 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-4877: fix precedence of unary -/+
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6044/2/fe/src/main/cup/sql-parser.cup
File fe/src/main/cup/sql-parser.cup:

Line 517: precedence left UMINUS, UPLUS;
actually, since they're identical, why not just have a single 'unarysign' or something like
that?


-- 
To view, visit http://gerrit.cloudera.org:8080/6044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I39cf388ae6e37e1b1e12ddea5fd3878c9c2620d1
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message