impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zach Amsden (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4936 and IMPALA-4915: Fix decimal overflow test
Date Sat, 18 Feb 2017 05:43:09 GMT
Zach Amsden has uploaded a new patch set (#2).

Change subject: IMPALA-4936 and IMPALA-4915: Fix decimal overflow test

IMPALA-4936 and IMPALA-4915: Fix decimal overflow test

The root cause of both behaviors turned out to be the same - a
missing std:: caused the wrong abs() function to be used.  Due
to details of IEEE floating point representation, this actually
masked another bug, as NaN is often represented as all 1-bits,
which fails the overflow test.  Since the implicit conversion to
int lost precision, we ended up storing large numbers that don't
actually represent valid decimal numbers in the range when the
value happened to be +/- Infinity.  This caused the rendering
back to ASCII characters to go awry, but is otherwise harmless.

Testing: updated expr test with correctly fixed test cases.
For some reason, it seemed the test passed before that, and I
found that it wasn't correctly validating some of the NULL cases.

Change-Id: I8de7440a585c1d3d937fcbb435b9ead77e7b5a63
M be/src/exprs/
M be/src/runtime/decimal-value.inline.h
2 files changed, 14 insertions(+), 15 deletions(-)

  git pull ssh:// refs/changes/68/6068/2
To view, visit
To unsubscribe, visit

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8de7440a585c1d3d937fcbb435b9ead77e7b5a63
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Jim Apple <>
Gerrit-Reviewer: Michael Ho

View raw message