impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4904,IMPALA-4914: whitelist workload "targeted-stress" for exhaustive tests
Date Fri, 17 Feb 2017 20:07:33 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-4904,IMPALA-4914: whitelist workload "targeted-stress" for exhaustive
tests
......................................................................


Patch Set 2:

(9 comments)

http://gerrit.cloudera.org:8080/#/c/6002/3//COMMIT_MSG
Commit Message:

Line 7: IMPALA-4904,IMPALA-4914: whitelist workload "targeted-stress" for exhaustive tests
long line


Line 29: An exhaustive build+test run showed test_ddl_stress and TestSpillStress
Roughly how much longer does this make exhaustive runs?


http://gerrit.cloudera.org:8080/#/c/6002/3/bin/run-all-tests.sh
File bin/run-all-tests.sh:

PS3, Line 100:   `
For my education: what do the three X's mean


PS3, Line 102: 
I don't think I've seen this idiom before. I recognize it is in HEAD already, but, for the
purposes of my own education, is this command substitution where the command contains only
whitespace, thereby just acting like "remove these backticks and all the space between them"?


http://gerrit.cloudera.org:8080/#/c/6002/3/buildall.sh
File buildall.sh:

Line 188:            "its dependencies. If already running, all services are restarted."\
What happened to the spaces?


PS3, Line 196: ONLY APPLIES to suites with workloads:"\
             :            "functional-query, targeted-stress"
This seems likely to become stale if that changes, as it may not show up to the author of
a change to run-all-tests.sh. Is there anything to be done about that?


http://gerrit.cloudera.org:8080/#/c/6002/3/tests/custom_cluster/test_spilling.py
File tests/custom_cluster/test_spilling.py:

PS3, Line 56: 
Would it be worthwhile or even possible to fix it to be more typical? If so, should that be
this patch or should it be a new JIRA?


PS3, Line 66: 
This one I don't quite understand. The CustomClusterTestSuite presumably shuts down impalad,
but that's OK once this test is done, yes?


http://gerrit.cloudera.org:8080/#/c/6002/3/tests/stress/test_ddl_stress.py
File tests/stress/test_ddl_stress.py:

Line 59
Does removing this (to pytest.mark.parametrize) change the possible orderings of the DDL calls?


-- 
To view, visit http://gerrit.cloudera.org:8080/6002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6bd5bbd380e636d680368e908519b042d79dfec
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message