impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Russell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3406: [DOCS] Empty the original Cloudera FAQ
Date Thu, 16 Feb 2017 22:33:31 GMT
John Russell has posted comments on this change.

Change subject: IMPALA-3406: [DOCS] Empty the original Cloudera FAQ
......................................................................


Patch Set 1:

(2 comments)

I made these changes but now when I push to gerrit I get:

To ssh://max-webster@gerrit.cloudera.org:29418/Impala-ASF
 ! [remote rejected] HEAD -> refs/for/master (change http://gerrit.cloudera.org:8080/5802
closed)
error: failed to push some refs to 'ssh://max-webster@gerrit.cloudera.org:29418/Impala-ASF'

This after doing rebases against master and/or asf-gerrit where the list of commits was quite
long.  (This gerrit #5802 it's complaining about is "IMPALA-4829: Change default Kudu read
behavior for "RYW"" which gerrit says is already merged.)

http://gerrit.cloudera.org:8080/#/c/6003/1/docs/topics/impala_faq.xml
File docs/topics/impala_faq.xml:

Line 235
> Can you file a JIRA against Apache Impala (with component Docs) to add back
Done. https://issues.cloudera.org/browse/IMPALA-4947


PS1, Line 44: It will contain questions and answers
            :       of interest to the Apache Impala developer community, rather than FAQs
            :       for Impala end users.
> I think this should be omitted for now. Why hamstring ourselves?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib81242f0981c04fff99e2c27e06a8d9f4da34c9f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Greg Rahn <grahn@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message