impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4937: Remove unused kudu scanner keep alive variable
Date Thu, 16 Feb 2017 22:25:13 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4937: Remove unused kudu scanner keep alive variable
......................................................................


IMPALA-4937: Remove unused kudu scanner keep alive variable

gflag kudu_scanner_keep_alive_period_us is defined but not
used. The same functionality is provided by
kudu_scanner_keep_alive_period_sec (in seconds), which works.
The kudu_scanner_keep_alive_period_us flag is removed by
this patch.

Change-Id: I99f56f93f1ff8543cbe415542464a053b24968e2
Reviewed-on: http://gerrit.cloudera.org:8080/6021
Reviewed-by: Sailesh Mukil <sailesh@cloudera.com>
Reviewed-by: Alex Behm <alex.behm@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/exec/kudu-scan-node.cc
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Sailesh Mukil: Looks good to me, but someone else must approve
  Alex Behm: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/6021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I99f56f93f1ff8543cbe415542464a053b24968e2
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>

Mime
View raw message