impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4821: Update AVG() for DECIMAL V2
Date Thu, 16 Feb 2017 21:29:35 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-4821: Update AVG() for DECIMAL_V2
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/6038/1/be/src/exprs/aggregate-functions-ir.cc
File be/src/exprs/aggregate-functions-ir.cc:

Line 450:     DCHECK_EQ(sum_scale, output_scale);
> I don't think we need this DCHECK since it was just an artificial restricti
It was mostly for ensuring the compatibility with DECIMAL_V1. I can convert that to a comment
instead.


http://gerrit.cloudera.org:8080/#/c/6038/1/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

Line 408:     size_t from_offset = expr.find("from");
> please add a short comment explaining this.
Added some comments. I'll it call it a query for the lack of better term.


http://gerrit.cloudera.org:8080/#/c/6038/1/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java
File fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java:

Line 335:         analyzer.getQueryOptions().isDecimal_v2()) {
> let's add a comment:
Done


Line 338:       return ScalarType.createAdjustedDecimalType(resultPrecision, resultScale);
> I guess this works out as the same type as falling through and taking the c
I anticipate the removal of createClippedDecimalType() in some future version. I'll keep it
this way if you don't mind.


-- 
To view, visit http://gerrit.cloudera.org:8080/6038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28f5ef0370938440eb5b1c6d29b2f24e6f88499f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message