impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3403: [DOCS] Pare back irrelevant installation info
Date Thu, 16 Feb 2017 18:13:41 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-3403: [DOCS] Pare back irrelevant installation info
......................................................................


Patch Set 1:

(2 comments)

Thanks for doing this!

http://gerrit.cloudera.org:8080/#/c/6005/1/docs/topics/impala_install.xml
File docs/topics/impala_install.xml:

Line 48:       When you work with or contribute to the Apache Impala project, you are typically
in a developer
This is odd wording. I think it might be better to say that this guide has instructions for
people who have built from source without presuming what people call their "role".


Line 66:           for build instructions.
I think the README.md is the best place for build instructions, since that is tied with the
tarball, while the wiki is whatever the latest thing is.


-- 
To view, visit http://gerrit.cloudera.org:8080/6005
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia81b1afbf04b93c322b9829d9e05e7af4243c37c
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Greg Rahn <grahn@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message