impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read
Date Wed, 15 Feb 2017 20:04:43 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read

Patch Set 6:

File be/src/exec/

Line 149: 
> I think Thomas is right and the query may crash if there is a difference in
I couldn't reproduce any failures, but looking at TupleDescriptor I agree it seems like it
could be possible to crash. Good call Thomas & Alex. I'll check that here too.

Will the Kudu-side validation check that the projection is 100% identical to what the scan
token expects? Nullability etc. included?
In theory it should, thought it looks like it's missing on the Kudu side as well, so I filed
a JIRA on them . Thanks for pointing this
File fe/src/main/java/org/apache/impala/planner/

Line 161:       if (!colType.matchesType(kuduColType)) {
> Shouldn't this use equals() instead of matchesType()?

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I6d43f5bb9811e728ad592933066d006c8fb4553a
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Sailesh Mukil <>
Gerrit-Reviewer: Thomas Tauber-Marshall <>
Gerrit-HasComments: Yes

View raw message