impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zach Amsden (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2020: Make it easy to work with big numbers
Date Wed, 15 Feb 2017 05:54:46 GMT
Zach Amsden has uploaded a new patch set (#4).

Change subject: IMPALA-2020: Make it easy to work with big numbers
......................................................................

IMPALA-2020: Make it easy to work with big numbers

Well the generic form turned out to not be super useful because
we generally only use these inside strings during tests.  In
lieu of having a general purpose function, let's just get rid of
the need to call some special large number init function.

Testing: Ran this in godbolt:

__int128_t val = AllNines<__int128_t>(38);

bignines:
        .quad   687399551400673279
        .quad   5421010862427522170

Ran this in Python:

>>> print 687399551400673279 + (5421010862427522170 * 2**64)
99999999999999999999999999999999999999
>>>

Looks legit.

Change-Id: I5095a366d914cebb0b64bd434a08dbb55c90ed30
---
M be/src/benchmarks/overflow-benchmark.cc
M be/src/common/init.cc
M be/src/util/decimal-util.cc
M be/src/util/decimal-util.h
4 files changed, 8 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/5902/4
-- 
To view, visit http://gerrit.cloudera.org:8080/5902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5095a366d914cebb0b64bd434a08dbb55c90ed30
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>

Mime
View raw message