impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4809: Enable support for DECIMAL V2 in decimal casting.py
Date Wed, 15 Feb 2017 02:47:47 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-4809: Enable support for DECIMAL_V2 in decimal_casting.py
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/5989/1/tests/query_test/test_decimal_casting.py
File tests/query_test/test_decimal_casting.py:

PS1, Line 34: casts from floats
> is this true? i don't see where it casts from float to decimal. maybe this 
Done


PS1, Line 48: precisin
> precision
Done


Line 83:     # TODO: Fix casting from double to decimal for precision > 38.
> what does this mean? today it truncates on double to decimal cast.
Due to IMPALA-4936, the cast from double to decimal doesn't always return null when it overflows.
So, use casting from string for now to verify the behavior for now.


PS1, Line 161: is_decimal_v2
> how about:
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5989
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf2c8c9d360ad92cbdc5ce902ee742ec4408a8a3
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message