impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4920: custom cluster tests: fix generation of py.test options
Date Tue, 14 Feb 2017 21:09:46 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4920: custom cluster tests: fix generation of py.test options
......................................................................


IMPALA-4920: custom cluster tests: fix generation of py.test options

This patch fixes a problem in which unnecessary quote characters were
part of some impala-py.test arguments for running the custom cluster
tests. The bug was causing py.test metadata files as described by the
py.test options --junit-xml and --result-log to end up outside the
intended path for such artifacts. By removing the unnecessary escaped
quotes, custom cluster py.test metadata artifacts will now be in the
proper location. I doubly made sure it was safe to remove these quotes
by adding a space in the RESULTS_DIR. The space isn't expanded but is
instead properly treated as part of RESULTS_DIR.

Change-Id: If6a56bc6bca826a8b50340e5caea7687441899e6
Reviewed-on: http://gerrit.cloudera.org:8080/5978
Reviewed-by: Jim Apple <jbapple-impala@apache.org>
Tested-by: Impala Public Jenkins
---
M tests/run-custom-cluster-tests.sh
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Jim Apple: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/5978
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If6a56bc6bca826a8b50340e5caea7687441899e6
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>

Mime
View raw message