impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR](asf-site) A blog post about IMPALA-4916
Date Tue, 14 Feb 2017 17:42:32 GMT
Jim Apple has posted comments on this change.

Change subject: A blog post about IMPALA-4916
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/5995/1//COMMIT_MSG
Commit Message:

PS1, Line 7: A blog post about IMPALA-4916
> It might be helpful to specify which files contain the actual article conte
Done


http://gerrit.cloudera.org:8080/#/c/5995/1/nikola_site_generator/posts/where-did-i-leave-my-keys.md
File nikola_site_generator/posts/where-did-i-leave-my-keys.md:

PS1, Line 43: SetsContainTheirElements
> Minor stylistic point. Let's follow strict PEP-8 for blog posts. PEP-8 call
I'v changed it to more closely match to code in tests/. To encourage developers to write blog
posts, I'd suggest we should make it as easy as possible, partially by not requiring them
to set up new editor defaults for Python style. This is especially true if someone wants to
post about some Python code already in Impala - presumably they wouldn't rewrite it to match
PEP-8. What do you think?


PS1, Line 44: s.__iter__()
> Nitiest of nits: while this is legal, and __iter__ is the method that retur
Thanks! The double underscore was bothering me.


http://gerrit.cloudera.org:8080/#/c/5995/1/nikola_site_generator/requirements.txt
File nikola_site_generator/requirements.txt:

PS1, Line 9: 
> Have you tested that after removing this, nikola still works on a Mac?
Good point; I have not. I have now gone through my list of general purpose computing devices
I have logins for and realized that not a single one is a Mac(!). Do you have a Mac with a
Python environment that is compatible with testing this?


-- 
To view, visit http://gerrit.cloudera.org:8080/5995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa90bf5621ef6466a4821f77a6e8a8b20c5512ae
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message