impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laurel Hale (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3411 [DOCS] Rework Impala governance topics to be generic.
Date Tue, 14 Feb 2017 04:16:59 GMT
Laurel Hale has posted comments on this change.

Change subject: IMPALA-3411 [DOCS] Rework Impala governance topics to be generic.
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

Just a couple of "writing" nits, but it built very cleanly, all your changes came through,
and you did a nice job of writing around the Cloudera references.

http://gerrit.cloudera.org:8080/#/c/5957/3/docs/topics/impala_auditing.xml
File docs/topics/impala_auditing.xml:

PS3, Line 39: To monitor how Impala data is being used within your organization, ensure
            :       that your Impala authorization and authentication policies are effective,
            :       and detect attempts at intrusion or unauthorized access to Impala
            :       data, you can use the auditing feature in Impala 1.2.1 and higher
Really long, rambling sentence. Could be broken up to make it easier to parse.


PS3, Line 60: s
Should be "each log file" (singular)


-- 
To view, visit http://gerrit.cloudera.org:8080/5957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I192bc2d1de89e55418c045d1a0e5433cf02cf782
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi <ambreen.kazi@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <ambreen.kazi@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message