impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4370: Divide and modulo result types for DECIMAL version V2
Date Tue, 14 Feb 2017 03:16:53 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-4370: Divide and modulo result types for DECIMAL version V2
......................................................................


Patch Set 12: Code-Review+1

(7 comments)

Carry Michael and Zach's +1.

http://gerrit.cloudera.org:8080/#/c/5952/11/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

PS11, Line 1293: V2 entries have
> the V2's entry will have
Done


Line 1298:     // Either testing version 1, or the results for version 2 were not specified.
> May want to DCHECK(!v2 || (!expected[1].null && expected[1].precision == 0)
Isn't that trivially true, though, given it's just the inverse of the above if-stmt?


PS11, Line 1392:   { "cast(1 as decimal(38,0)) % cast(3 as decimal(38,0))",
               :     {{ false, 1, 38, 0 }} },
> Can we also have some cases such as:
Done


http://gerrit.cloudera.org:8080/#/c/5952/11/be/src/runtime/decimal-value.inline.h
File be/src/runtime/decimal-value.inline.h:

PS11, Line 237: scale and
> scale
Done


Line 237:   // We need to scale x up by the result scale and then do an integer divide.
> Please fix this comment - "We need to scale x up by the result scale and th
Done


Line 238:   // This truncates the result to the output scale.
> ditto
Done


PS11, Line 239: implement rounding when decimal_v2=true.
> May help to rephrase this to state that we need to implement rounding for d
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83e7f7787edfa4b4bddc25945090542a0e90881b
Gerrit-PatchSet: 12
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message