impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic
Date Tue, 14 Feb 2017 02:20:50 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic
......................................................................


Patch Set 4: -Code-Review

> I did a build and got a lot of errors and it doesn't look like the
 > build picked up any of your changes. I'm not sure why this is
 > happening. Suggest you try to build before you do your next patch
 > set.

I ran a test build: http://jenkins.impala.io:8080/job/docs-build/169/console

It succeeded, in that dita returned status 0, which is unix code for OK return. OTOH, the
output produced is missing kerberos. This is probably a dita bug - when it misses output,
it should return non-0.

-- 
To view, visit http://gerrit.cloudera.org:8080/5962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi <ambreen.kazi@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <ambreen.kazi@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message