impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Revert "IMPALA-4829: Change default Kudu read behavior for "RYW""
Date Mon, 13 Feb 2017 23:09:12 GMT
Dan Hecht has posted comments on this change.

Change subject: Revert "IMPALA-4829: Change default Kudu read behavior for "RYW""
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5970/1/be/src/exec/kudu-scanner.cc
File be/src/exec/kudu-scanner.cc:

Line 49:     "result in using READ_LATEST.");
> That is meant to indicate that invalid values provided for this flag result
Maybe just delete that sentence. A user shouldn't really rely on this anyway - they should
just specify a valid mode.


-- 
To view, visit http://gerrit.cloudera.org:8080/5970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I995dec543946c9e0f79bc5b7e82568060a9d8262
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message