impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ambreen Kazi (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3411 [DOCS] Rework Impala governance topics to be generic.
Date Mon, 13 Feb 2017 18:34:32 GMT
Ambreen Kazi has posted comments on this change.

Change subject: IMPALA-3411 [DOCS] Rework Impala governance topics to be generic.
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5957/1//COMMIT_MSG
Commit Message:

Line 12: to use cluster management software with a focus on governance.
> Why not always remove them?
We will eventually remove them from the source once we've sanity checked individual topics
and made sure that what remains outside the hidden tags is not awkward and flows well. 

Removing all the 'hidden' content will be a global operation. For now though, with three writers
working on the source, it's not a good idea to spot fix these references.


http://gerrit.cloudera.org:8080/#/c/5957/2/docs/topics/impala_lineage.xml
File docs/topics/impala_lineage.xml:

Line 61:       lineage data generated by Impala into graphs for easy visualization.
> These are no longer hidden and there is a mismatched ph tag at the end.
Thanks -- fixed the ph tag and another missing p tag -- the text is hidden in my build now.


-- 
To view, visit http://gerrit.cloudera.org:8080/5957
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I192bc2d1de89e55418c045d1a0e5433cf02cf782
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi <ambreen.kazi@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <ambreen.kazi@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message