impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4370: Divide and modulo result types for DECIMAL version V2
Date Mon, 13 Feb 2017 18:28:34 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-4370: Divide and modulo result types for DECIMAL version V2
......................................................................


Patch Set 8:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5952/8/be/src/runtime/decimal-value.inline.h
File be/src/runtime/decimal-value.inline.h:

PS8, Line 228: other
not your change but it may be clearer to call this divisor.


http://gerrit.cloudera.org:8080/#/c/5952/8/tests/query_test/test_decimal_queries.py
File tests/query_test/test_decimal_queries.py:

PS8, Line 51:     new_vector.get_value('exec_option')['decimal_v2'] = vector.get_value('decimal_v2')
            :     new_vector.get_value('exec_option')['batch_size'] = vector.get_value('batch_size')
or simply do cls.ImpalaTestMatrix.add_dimension(create_exec_option_dimension_from_dict({'decimal_v2':['false',
'true'], 'batch':[0,1])) in add_test_dimensions().


-- 
To view, visit http://gerrit.cloudera.org:8080/5952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83e7f7787edfa4b4bddc25945090542a0e90881b
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message