impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4370: Divide and modulo result types for DECIMAL version V2
Date Sat, 11 Feb 2017 09:52:32 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-4370: Divide and modulo result types for DECIMAL version V2

Patch Set 6:

File fe/src/main/java/org/apache/impala/analysis/

Line 100:       ArithmeticExpr.Operator op, TQueryOptions queryOptions) throws AnalysisException
instead of queryoptions, how about just passing a bool in here? narrower interfaces are easier
to understand.

Line 152:    * on whether DECIMAL version 1 or DECIMAL version 2 is enabled.
since we're going to toss out the v1 behavior when we sunset cdh5, leave a bunch of todos
in place so we know what exactly needs to change?

Line 233:    *    precision.  But an algorithm of reducing scale to a minimum reduction of
6 is
"to a minimum of 6"
File fe/src/main/java/org/apache/impala/catalog/

Line 138:   public static ScalarType createDecimalTypeClipPrecScale(int precision, int scale)
how about simply createClippedDecimalType()? or truncated instead of clipped. same for createAdjustedDecimalType.

same checkstates as in 'adjusted' below?

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I83e7f7787edfa4b4bddc25945090542a0e90881b
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Marcel Kornacker <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Zach Amsden <>
Gerrit-HasComments: Yes

View raw message