impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4810: fix incorrect expr-test decimal types
Date Sat, 11 Feb 2017 03:30:16 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4810: fix incorrect expr-test decimal types
......................................................................


IMPALA-4810: fix incorrect expr-test decimal types

Many of the types for the decimal round/truncate and related tests
are incorrect. This was never caught because the type was only used
by the string parser, and larger types would work. The change for
IMPALA-4370 adds validation of the expected type, so fix these.

Change-Id: I1e750fc01ab64ff27182670d8e823c012743804b
Reviewed-on: http://gerrit.cloudera.org:8080/5959
Reviewed-by: Dan Hecht <dhecht@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/exprs/expr-test.cc
M be/src/runtime/types.cc
2 files changed, 101 insertions(+), 87 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Dan Hecht: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/5959
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1e750fc01ab64ff27182670d8e823c012743804b
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>

Mime
View raw message