impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL V2
Date Sat, 11 Feb 2017 02:57:21 GMT
Hello Dan Hecht,

I'd like you to reexamine a change.  Please visit

to look at the new patch set (#3).

Change subject: IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2

IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2

Currently, codegen supports converting type attributes (e.g.
decimal type's precision and scale, type's size) obtained via
calls to FunctionContextImpl::GetFnAttr() (previously
Expr::GetConstantInt()) in cross-compiled code to runtime constants.
This change extends this support for the query option DECIMAL_V2.

To test this change, this change also handles a subset of IMPALA-2020:
casting between decimal values is  updated to support rounding (instead
of truncation) when decimal_v2 is true.

This change also cleans up the existing code by moving the codegen
logic Expr::InlineConstant() to the codegen module and the type
related logic in Expr::GetConstantInt() to FunctionContextImpl.

Change-Id: I2434d240f65b81389b8a8ba027f980a0e1d1f981
M be/src/benchmarks/
M be/src/codegen/
M be/src/codegen/
M be/src/codegen/llvm-codegen.h
M be/src/exec/
M be/src/exec/partitioned-aggregation-node.h
M be/src/exprs/
M be/src/exprs/
M be/src/exprs/
M be/src/exprs/
M be/src/exprs/
M be/src/exprs/decimal-operators.h
M be/src/exprs/
M be/src/exprs/
M be/src/exprs/
M be/src/exprs/expr.h
M be/src/exprs/
M be/src/exprs/
M be/src/runtime/decimal-value.inline.h
M be/src/runtime/
M be/src/runtime/
M be/src/runtime/runtime-state.h
M be/src/service/
M be/src/udf/udf-internal.h
M be/src/udf/
M be/src/udf/udf-test-harness.h
M be/src/udf/
M testdata/workloads/functional-query/queries/QueryTest/decimal.test
M tests/query_test/
29 files changed, 640 insertions(+), 488 deletions(-)

  git pull ssh:// refs/changes/50/5950/3
To view, visit
To unsubscribe, visit

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2434d240f65b81389b8a8ba027f980a0e1d1f981
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Michael Ho <>

View raw message