impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4370: Divide and modulo result types for DECIMAL version V2
Date Fri, 10 Feb 2017 22:25:08 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-4370: Divide and modulo result types for DECIMAL version V2
......................................................................


Patch Set 7:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/5952/6/fe/src/main/java/org/apache/impala/catalog/ScalarType.java
File fe/src/main/java/org/apache/impala/catalog/ScalarType.java:

PS6, Line 115: precision
> Can precision be > MAX_PRECISION in this case ?
Yeah I thought about adding a check for that but it wasn't entirely clear to me so I left
it alone for now.


PS6, Line 138: ClipPrecScale
> May help to clarify that how this function and the *AdjustPrecScale() are r
I don't think it will be as simple as use one when v1 is enabled and the other when v2 is
enabled.  I think there are some cases in v2 where we still may want to clip.


Line 148:    * preserve at least MIN_ADJUSTED_SCALE for scale (unless the desired scale was
less).
> MIN_ADJUSTED_SCALE for scale (unless ...)
Done


http://gerrit.cloudera.org:8080/#/c/5952/6/fe/src/main/java/org/apache/impala/catalog/Type.java
File fe/src/main/java/org/apache/impala/catalog/Type.java:

PS6, Line 65: 
> nit: blank space
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83e7f7787edfa4b4bddc25945090542a0e90881b
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message