impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL V2
Date Fri, 10 Feb 2017 18:15:31 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

Please take a look at whether it makes sense to add coverage in test_decimal_casting.py before
committing. Also, please see my question earlier about whether perf (for v2=false) was checked.

http://gerrit.cloudera.org:8080/#/c/5950/1/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

Line 1334:     {{ false, 999999999, 9, 0 }, { true, 0, 9, 0 }} },
> Modified the test above to show rounding of 0.12344 vs 0.12345. Is that wha
Yes


http://gerrit.cloudera.org:8080/#/c/5950/1/testdata/workloads/functional-query/queries/QueryTest/decimal.test
File testdata/workloads/functional-query/queries/QueryTest/decimal.test:

Line 469: ---- RESULTS
> The query above was run with v2=false. Did you mean something else ?
Yes. Somehow I didn't see that.


-- 
To view, visit http://gerrit.cloudera.org:8080/5950
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2434d240f65b81389b8a8ba027f980a0e1d1f981
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message