impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4810: fix incorrect expr-test decimal types
Date Thu, 09 Feb 2017 23:24:55 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-4810: fix incorrect expr-test decimal types
......................................................................


Patch Set 1:

> Why doesn't this change also pull in the validation of the
 > resulting Decimal types to validate the fixes ?

I was being lazy. Pulled that in, along with a formatting change needed so that the frontend
and backend agree on how to print types.

-- 
To view, visit http://gerrit.cloudera.org:8080/5959
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e750fc01ab64ff27182670d8e823c012743804b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message