impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven
Date Thu, 09 Feb 2017 16:45:16 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven
......................................................................


Patch Set 4:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5933/4/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

Line 1288:     {{ false, 2230, 5, 3 }, { false, 2230, 5, 3 }} },
> this isn't super-easy to read, how about having the v1 and v2 results on se
The next patch introduces actual differences, and lines up each pair of expected results:
https://gerrit.cloudera.org/#/c/5952/


Line 1345:   for (int v2 = 0; v2 <= 1; ++v2) {
> for (int v2: {0, 1}) will do the same
Thanks, added this to https://gerrit.cloudera.org/#/c/5952/


http://gerrit.cloudera.org:8080/#/c/5933/4/be/src/testutil/impalad-query-executor.h
File be/src/testutil/impalad-query-executor.h:

Line 87:   void pushExecOption(const std::string& exec_option) {
> nit: fn names are not according to our style guide
oops, i knew something didn't look right. fixed it in https://gerrit.cloudera.org/#/c/5952/


-- 
To view, visit http://gerrit.cloudera.org:8080/5933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieffb2573de46bba64d1b4e8caf15cc0238a84ea1
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message