impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2020: Add rounding when casting from decimal to int
Date Thu, 09 Feb 2017 05:22:01 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-2020: Add rounding when casting from decimal to int
......................................................................


Patch Set 2:

I'm not opposed to cleaning up the AnyVal stuff like that, but given that udf.h stuff dictates
UDF compatibility, it's not completely trivial. It doesn't look like it would break binary
compatibility though. But, in case something goes wrong, how about we do that as a separate
change so it could be backed out without affecting the decimal work? It doesn't look like
the decimal stuff will depend on it, right?

-- 
To view, visit http://gerrit.cloudera.org:8080/5951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2daf186b4770a022f9cb349d512067a1dd624810
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message