impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ambreen Kazi (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala security topics to be generic
Date Wed, 08 Feb 2017 22:25:01 GMT
Ambreen Kazi has posted comments on this change.

Change subject: IMPALA-3410 [DOCS] Rework Impala security topics to be generic

Patch Set 1:

Commit Message:

Line 10: topics. References to CDH and Cloudera Manager docs/products have been either
> wrap at 70 characters (the red line)
File docs/shared/impala_common.xml:

PS1, Line 608: audience="Cloudera"
> This should be audience="hidden". (There shouldn't be any audience="Clouder
I found it like this. Changed to hidden now.

PS1, Line 616: appropropriate
> note to self - typo
File docs/topics/impala_authorization.xml:

PS1, Line 319: recommends
             :           managing privileges through SQL statements, as described in
             :           <xref href="impala_authorization.xml#sentry_service"/>. If
you are still using policy files, plan to
             :           migrate to the new approach some time in the future.
> Should we genericize the wording but keep the recommendation to use policy 
Genericized the wording. The recommendation should be to use the SQL statements. I've removed
the 'some time in the future' wording as well because it's been a while since the Sentry service

Line 850:           To enable URIs in per-DB policy files, the Java configuration option <codeph>sentry.allow.uri.db.policyfile</codeph>
must be set to <codeph>true</codeph>.
> Shorter lines maker for easier reviews

PS1, Line 853: </p>
> For example:

PS1, Line 951: we strongly recommend
> I've stayed away from "we recommend" because there isn't the same commitmen
I've reworded this note to make it more of an instruction rather than a suggestion/recommendation.
File docs/topics/impala_security.xml:

PS1, Line 40: the Apache Sentry
            :       open source project
> Optional: can be shortened to just "Apache Sentry".

PS1, Line 45: focussed
> focused (American spelling)

PS1, Line 116:  
> hyphen, like previous instance
File docs/topics/impala_security_install.xml:

PS1, Line 38:  
> Trailing blank.
File docs/topics/impala_ssl.xml:

PS1, Line 39:  
> Let's start the text on the line after the <indexterm> tag.

PS1, Line 44: <!-- Formerly: conref="../shared/CDHVariables.xml#xd_583c10bfdbd326ba-3ca24a24-13d801432
> We can get get of this comment.

PS1, Line 240:  
> Trailing blank.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5c4431f3236b18fc282343ed98513f0e578130e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi <>
Gerrit-Reviewer: Ambreen Kazi <>
Gerrit-Reviewer: Jim Apple <>
Gerrit-Reviewer: John Russell <>
Gerrit-Reviewer: Laurel Hale <>
Gerrit-HasComments: Yes

View raw message