impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ishaan Joshi (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4839: Remove implicit 'localhost' for KUDU MASTER HOSTS
Date Wed, 08 Feb 2017 06:42:51 GMT
Ishaan Joshi has posted comments on this change.

Change subject: IMPALA-4839: Remove implicit 'localhost' for KUDU_MASTER_HOSTS
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5877/7/tests/conftest.py
File tests/conftest.py:

Line 317:   try:
With a yield fixture, py.test treats everything after the yield as teardown, so you probably
don't need the finally. Additionally, if you're at 2.10 or above, you don't even need the
yield fixture marker.

Ref: http://doc.pytest.org/en/latest/fixture.html#fixture-finalization-executing-teardown-code


-- 
To view, visit http://gerrit.cloudera.org:8080/5877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9df71480a165f4ce21ae3edab6ce7227fbf76f77
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Ishaan Joshi <ishaan@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message