impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven
Date Wed, 08 Feb 2017 01:08:28 GMT
Hello Michael Ho, Zach Amsden,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5933

to look at the new patch set (#3).

Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven
......................................................................

IMPALA-4810: Make DECIMAL expr-test cases table driven

That way, we can easily run all test cases with both:
  DECIMAL_V2={false, true}

Currently, the behavior is the same, but as we work on IMPALA-4810,
the expected results will differ.

Change-Id: Ieffb2573de46bba64d1b4e8caf15cc0238a84ea1
---
M be/src/exprs/expr-test.cc
M be/src/testutil/impalad-query-executor.h
2 files changed, 119 insertions(+), 70 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/5933/3
-- 
To view, visit http://gerrit.cloudera.org:8080/5933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieffb2573de46bba64d1b4e8caf15cc0238a84ea1
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>

Mime
View raw message