impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven
Date Wed, 08 Feb 2017 01:00:52 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven
......................................................................


Patch Set 2:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/5933/1//COMMIT_MSG
Commit Message:

PS1, Line 10:  DECIMAL_V2
> DECIMAL_V2
Done


http://gerrit.cloudera.org:8080/#/c/5933/1/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

PS1, Line 1286: decimalCases
> These are just for decimal arithmetic, right ? May be just this should be d
they are for any expression that results in a decimal type.  we can put CAST cases in here
too.


PS1, Line 1345: ++v2
> ++v2
Done


PS1, Line 6242: enable_expr_rewr
> Please consider adding clearAllExecOptions() in ImpaladQueryExecutor too.
Done


PS1, Line 6243:   executor_->clearExecOptions();
              :   executor_->pushExecOption("ENABLE_EXPR_REWRITES=0");
              :   executor_->pushExecOption("DISABLE_CODEGEN=0");
> May be these can use your the pushExecOption();
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieffb2573de46bba64d1b4e8caf15cc0238a84ea1
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message