impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven
Date Wed, 08 Feb 2017 00:25:39 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5933/1//COMMIT_MSG
Commit Message:

PS1, Line 10:  DECIMAL_V1
DECIMAL_V2


http://gerrit.cloudera.org:8080/#/c/5933/1/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

PS1, Line 6242: options.clear();
Please consider adding clearAllExecOptions() in ImpaladQueryExecutor too.


PS1, Line 6243:   options.push_back("ENABLE_EXPR_REWRITES=0");
              :   options.push_back("DISABLE_CODEGEN=0");
              :   options.push_back("EXEC_SINGLE_NODE_ROWS_THRESHOLD=0");
May be these can use your the pushExecOption();


-- 
To view, visit http://gerrit.cloudera.org:8080/5933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieffb2573de46bba64d1b4e8caf15cc0238a84ea1
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message