impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Russell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala security topics to be generic
Date Wed, 08 Feb 2017 00:08:48 GMT
John Russell has posted comments on this change.

Change subject: IMPALA-3410 [DOCS] Rework Impala security topics to be generic
......................................................................


Patch Set 1:

(10 comments)

http://gerrit.cloudera.org:8080/#/c/5931/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

PS1, Line 608: audience="Cloudera"
This should be audience="hidden". (There shouldn't be any audience="Cloudera" left in the
master branch. Did you add this attribute, or find it already like this?)


http://gerrit.cloudera.org:8080/#/c/5931/1/docs/topics/impala_authorization.xml
File docs/topics/impala_authorization.xml:

PS1, Line 319: recommends
             :           managing privileges through SQL statements, as described in
             :           <xref href="impala_authorization.xml#sentry_service"/>. If
you are still using policy files, plan to
             :           migrate to the new approach some time in the future.
Should we genericize the wording but keep the recommendation to use policy files? Otherwise
it's not clear that GRANT and REVOKE are the preferred technique.


PS1, Line 853: </p>
For example:


PS1, Line 951: we strongly recommend
I've stayed away from "we recommend" because there isn't the same commitment of support as
in the commercial context. Let's find some imperative wording like "...wherever practical,
<do X>".


http://gerrit.cloudera.org:8080/#/c/5931/1/docs/topics/impala_security.xml
File docs/topics/impala_security.xml:

PS1, Line 45: focussed
focused (American spelling)


PS1, Line 116:  
hyphen, like previous instance


http://gerrit.cloudera.org:8080/#/c/5931/1/docs/topics/impala_security_install.xml
File docs/topics/impala_security_install.xml:

PS1, Line 38:  
Trailing blank.


http://gerrit.cloudera.org:8080/#/c/5931/1/docs/topics/impala_ssl.xml
File docs/topics/impala_ssl.xml:

PS1, Line 39:  
Let's start the text on the line after the <indexterm> tag.


PS1, Line 44: <!-- Formerly: conref="../shared/CDHVariables.xml#xd_583c10bfdbd326ba-3ca24a24-13d801432
We can get get of this comment.


PS1, Line 240:  
Trailing blank.


-- 
To view, visit http://gerrit.cloudera.org:8080/5931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5c4431f3236b18fc282343ed98513f0e578130e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Ambreen Kazi <ambreen.kazi@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <ambreen.kazi@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message