impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven
Date Wed, 08 Feb 2017 00:08:42 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5933/1/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

PS1, Line 1286: decimalCases
These are just for decimal arithmetic, right ? May be just this should be decimal_arithmetic_cases
?


PS1, Line 1345: v2++
++v2


-- 
To view, visit http://gerrit.cloudera.org:8080/5933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieffb2573de46bba64d1b4e8caf15cc0238a84ea1
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message