impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3909 (follow-up): Properly qualify min() and max() in header
Date Tue, 07 Feb 2017 21:02:09 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-3909 (follow-up): Properly qualify min() and max() in header
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5916/2//COMMIT_MSG
Commit Message:

Line 14: I tried to make a static_assert method that complained if names.h was
> Can it check if a using statement is transitively included? It wasn't clear
That I am not sure about. It would require some experimentation, partially because those links
were for the HEAD version of documentation, but the toolchain is on version 3.8.1.


-- 
To view, visit http://gerrit.cloudera.org:8080/5916
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8381d5b1fa072e89ac1f7f54959c02bf8e43b4b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message