impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3909 (follow-up): Properly qualify min() and max() in header
Date Tue, 07 Feb 2017 20:10:38 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-3909 (follow-up): Properly qualify min() and max() in header
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5916/1//COMMIT_MSG
Commit Message:

Line 7: IMPALA-3909 (follow-up): Properly qualify min() and max() in header
> Why?
because we require names to be fully qualified in headers.


http://gerrit.cloudera.org:8080/#/c/5916/1/be/src/exec/parquet-column-stats.h
File be/src/exec/parquet-column-stats.h:

Line 106:       min_value_ = std::min(min_value_, v);
> Also need #include <algorithm>
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5916
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8381d5b1fa072e89ac1f7f54959c02bf8e43b4b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message