impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4849: IllegalStateException from rewritten CASE expr
Date Tue, 07 Feb 2017 19:41:33 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-4849: IllegalStateException from rewritten CASE expr
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5917/1/fe/src/main/java/org/apache/impala/analysis/SelectList.java
File fe/src/main/java/org/apache/impala/analysis/SelectList.java:

Line 106:       if (!item.isStar()) item.setExpr(item.getExpr().reset());
nice catch


http://gerrit.cloudera.org:8080/#/c/5917/1/testdata/workloads/functional-query/queries/QueryTest/exprs.test
File testdata/workloads/functional-query/queries/QueryTest/exprs.test:

Line 2698: ---- TYPES
Not sure if the test framework will even run this without a RESULTS section. Better to add
it I think.


-- 
To view, visit http://gerrit.cloudera.org:8080/5917
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16ff88716b185e1d72d2bc603a42bd06c60ec18e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message