impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI
Date Tue, 07 Feb 2017 19:34:28 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5909/1/be/src/util/default-path-handlers.cc
File be/src/util/default-path-handlers.cc:

Line 163:       document->AddMember("jvm_pool", total, document->GetAllocator());
jvm_total


http://gerrit.cloudera.org:8080/#/c/5909/1/www/memz.tmpl
File www/memz.tmpl:

Line 92: <h3>JVM total pool memory usage</h3>
> Merely to indicate that we aggregate across all memory pools. Let me know i
It somewhat confused me, so might be better to omit.


-- 
To view, visit http://gerrit.cloudera.org:8080/5909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I543d4d428d7240e0f710d67973867162f2fcabc8
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message