impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4729: Implement REPLACE()
Date Tue, 07 Feb 2017 19:20:17 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-4729: Implement REPLACE()
......................................................................


Patch Set 15: Code-Review+1

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5776/15/be/src/exprs/string-functions-ir.cc
File be/src/exprs/string-functions-ir.cc:

PS15, Line 256: (context->GetFunctionState(FunctionContext::FRAGMENT_LOCAL));
nit: indent 4.


PS15, Line 362: result.len = ptr - result.ptr + bytes_remaining;
Feel free to ignore:

Move this line up to line 360 before the DCHECK and modify the DCHECK to DCHECK_LE(result.len,
buffer_space);


http://gerrit.cloudera.org:8080/#/c/5776/15/be/src/udf/udf.h
File be/src/udf/udf.h:

PS15, Line 598:   /// Note that the memory for the buffer of the new StringVal is managed
by Impala.
              :   /// Impala will handle freeing it. Callers should not call Free() on the
'ptr' of
              :   /// the StringVal returned.
Please add a similar comment to Resize().


-- 
To view, visit http://gerrit.cloudera.org:8080/5776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1780a7d8fee6d0db9dad148217fb6eb10f773329
Gerrit-PatchSet: 15
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message