impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4880: Clarify synchronization policy for 'done ' in KuduScanNode
Date Mon, 06 Feb 2017 19:32:46 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-4880: Clarify synchronization policy for 'done_' in KuduScanNode
......................................................................


Patch Set 3:

(2 comments)

looks fine to me

http://gerrit.cloudera.org:8080/#/c/5494/3/be/src/exec/kudu-scan-node.cc
File be/src/exec/kudu-scan-node.cc:

PS3, Line 218: (
nit: remove extraneous parens


Line 307:         done_ = true;
fix indentation


-- 
To view, visit http://gerrit.cloudera.org:8080/5494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72c5f1fecf4bcf737d71a1fa13e59361604485f0
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message