impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "anujphadke (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4738: STDDEV SAMP should return NULL for single record input
Date Mon, 06 Feb 2017 19:30:27 GMT
anujphadke has posted comments on this change.

Change subject: IMPALA-4738: STDDEV_SAMP should return NULL for single record input
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5800/3//COMMIT_MSG
Commit Message:

PS3, Line 9: In calculating the STDDEV_SAMP/VARIANCE of N rows a divion by
           : N-1 rows is involved. Hence STDDEV_SAMP/VARIANCE for a single
           : row involves a division by 0. This change returns a NULL instead
           : of a 0 when calculating STDDEV_SAMP/VARIANCE for a single row.
           : STDDE
> nit wrap at 80 chars
Done


Line 14: this does not involve  a division by 0. This matches the postgres
> please mention this matches postgres behavior
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide8af752cd8a2e554a2cd5a1ec948967a80de1fe
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <aphadke@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: anujphadke <aphadke@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message