impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2020: Make it easy to work with big numbers
Date Mon, 06 Feb 2017 19:14:27 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-2020: Make it easy to work with big numbers
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5902/2/be/src/util/decimal-util.h
File be/src/util/decimal-util.h:

PS2, Line 46: (
nit: extraneous parens


PS2, Line 47: -
nit: spaces around -


-- 
To view, visit http://gerrit.cloudera.org:8080/5902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5095a366d914cebb0b64bd434a08dbb55c90ed30
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-HasComments: Yes

Mime
View raw message