impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning
Date Mon, 06 Feb 2017 19:08:57 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning
......................................................................


Patch Set 6:

(3 comments)

AFAICT, IMPALA-1427 should have been resolved when we stopped printing the warning multiple
times.  So, what's the motivation for this change now? I'm not necessarily opposed to it,
but won't this make the warning less visible, and if so, what's the justification for that?

http://gerrit.cloudera.org:8080/#/c/5828/6//COMMIT_MSG
Commit Message:

Line 17: 
put a bullet for the new compile-time warning.


http://gerrit.cloudera.org:8080/#/c/5828/6/common/thrift/ImpalaInternalService.thrift
File common/thrift/ImpalaInternalService.thrift:

Line 324:   15: optional list<CatalogObjects.TTableName> tables_missing_diskids
this isn't used by the backend, so it's kinda unfortunate to carry it around with us in the
TQueryCtx. But it is consistent with tables_missing_stats, etc, so okay for now.

Oh, actually, table_missing_stats is used in ExecQueryOrDmlRequest(). Should we be doing something
similar for missing disk ids?


http://gerrit.cloudera.org:8080/#/c/5828/6/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java:

Line 614:             totalFiles_, numScanRangesNoDiskIds_, scanRanges_.size()));
does this get printed when the table lives on a FS that doesn't have a notion of disk ids,
e.g. S3?

not your change, but if we want to do it for this case, is there a reason we aren't doing
this for the missing stats case also?


-- 
To view, visit http://gerrit.cloudera.org:8080/5828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iddb132ff7ad66f3291b93bf9d8061bd0525ef1b2
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message