impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes
Date Mon, 06 Feb 2017 09:09:03 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-4822: Implement dynamic log level changes

Patch Set 6:

File be/src/util/

Line 83: static const string log_inputs[] = {"get_java_log", "set_java_log", "reset_java_log",
> Sorry, I didn't realize the log_inputs and the display_members were differe
Changes undone. Renamed a little as discussed offline.
File tests/webserver/

Line 43:     """ Helper method that polls a given url and asserts the return code is ok and
> nit: remove space before "Helper"

Line 48:   def test_log_level_callback(self):
> test_log_level

Line 50:     malformed inputs"""
> Does not test that the log level modifications are actually in effect.

Line 59:     # Set the log level of a class to TRACE anc confirm the setting is in place
> typo: and

Line 67:     self.get_and_check_status(get_loglevel_url, "TRACE")
> also check a different class and make sure it's still at DEBUG

Line 75:     self.get_and_check_status(get_loglevel_url, "DEBUG")
> also add tests for malformed inputs, e.g., a class that does not exist, emp
Added a few more tests. Also, per my understanding, in log4j, there is no such thing as a
class that does not exists. It accepts any class that we input (and sets a log level), since
we can actually load them at runtime, if it is not already loaded.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I588418e9bcb0b66d33138baf96207a5a35bfbd63
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Bharath Vissapragada <>
Gerrit-Reviewer: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Henry Robinson <>
Gerrit-HasComments: Yes

View raw message