impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning
Date Sat, 04 Feb 2017 01:54:08 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning
......................................................................


Patch Set 5: Code-Review+2

(2 comments)

Before you merge, let me ask Dan to take a quick look to see if he agrees with removing the
disk id stuff from the BE.

http://gerrit.cloudera.org:8080/#/c/5828/5//COMMIT_MSG
Commit Message:

Line 9: This commit,
remove


http://gerrit.cloudera.org:8080/#/c/5828/5/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java:

Line 610:       output.append(String.format("%smissing disk ids: " +
let's not output this when there are no missing disk ids


-- 
To view, visit http://gerrit.cloudera.org:8080/5828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iddb132ff7ad66f3291b93bf9d8061bd0525ef1b2
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message